From 241e340c3f571f440276eda00a6780e8500fce01 Mon Sep 17 00:00:00 2001
From: YunaiV <zhijiantianya@gmail.com>
Date: Mon, 19 May 2025 19:52:25 +0800
Subject: [PATCH] =?UTF-8?q?review=EF=BC=9A=E3=80=90ANTD=E3=80=91=E6=89=B9?=
 =?UTF-8?q?=E9=87=8F=E5=88=A0=E9=99=A4=E4=BB=A3=E7=A0=81?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 apps/web-antd/src/api/infra/codegen/index.ts  |  1 +
 .../src/api/infra/demo/demo01/index.ts        |  1 +
 .../dept-select-modal/dept-select-modal.vue   |  1 +
 .../src/views/bpm/model/form/index.vue        |  1 +
 apps/web-antd/src/views/bpm/model/index.vue   |  1 +
 apps/web-antd/src/views/infra/codegen/data.ts |  1 +
 .../src/views/infra/demo/demo01/data.ts       |  1 +
 .../src/views/infra/demo/demo01/index.vue     |  1 +
 apps/web-antd/src/views/system/role/index.vue |  1 +
 .../src/views/system/tenant/index.vue         | 19 ++++++++++++-------
 10 files changed, 21 insertions(+), 7 deletions(-)

diff --git a/apps/web-antd/src/api/infra/codegen/index.ts b/apps/web-antd/src/api/infra/codegen/index.ts
index 0760e752..c59347d7 100644
--- a/apps/web-antd/src/api/infra/codegen/index.ts
+++ b/apps/web-antd/src/api/infra/codegen/index.ts
@@ -21,6 +21,7 @@ export namespace InfraCodegenApi {
     createTime: Date;
     updateTime: Date;
     templateType: number;
+    // TODO @puhui999：使用后端统一配置。因为一般需要批量的团队，会一直需要。不需要的，一般一直不需要哈。
     deleteBatch: boolean;
     parentMenuId: number;
   }
diff --git a/apps/web-antd/src/api/infra/demo/demo01/index.ts b/apps/web-antd/src/api/infra/demo/demo01/index.ts
index 0fbd3141..94fb6330 100644
--- a/apps/web-antd/src/api/infra/demo/demo01/index.ts
+++ b/apps/web-antd/src/api/infra/demo/demo01/index.ts
@@ -47,6 +47,7 @@ export function deleteDemo01Contact(id: number) {
 }
 
 // 批量删除示例联系人
+// TODO @puhui999：注释风格哈。
 export function deleteDemo01ContactByIds(ids: number[]) {
   return requestClient.delete(
     `/infra/demo01-contact/delete-batch?ids=${ids.join(',')}`,
diff --git a/apps/web-antd/src/components/dept-select-modal/dept-select-modal.vue b/apps/web-antd/src/components/dept-select-modal/dept-select-modal.vue
index 69968ce3..561ab24e 100644
--- a/apps/web-antd/src/components/dept-select-modal/dept-select-modal.vue
+++ b/apps/web-antd/src/components/dept-select-modal/dept-select-modal.vue
@@ -1,3 +1,4 @@
+// TODO @芋艿：是否有更好的组织形式？！
 <script lang="ts" setup>
 import type { DataNode } from 'ant-design-vue/es/tree';
 
diff --git a/apps/web-antd/src/views/bpm/model/form/index.vue b/apps/web-antd/src/views/bpm/model/form/index.vue
index 6d86eeb0..c0b45af1 100644
--- a/apps/web-antd/src/views/bpm/model/form/index.vue
+++ b/apps/web-antd/src/views/bpm/model/form/index.vue
@@ -33,6 +33,7 @@ import FormDesign from './modules/form-design.vue';
 defineOptions({ name: 'BpmModelCreate' });
 
 // TODO 这个常量是不是所有 apps 都可以使用， 放 @utils/constant.ts 不能共享， @芋艿 这些常量放哪里合适！
+// TODO @jason：/Users/yunai/Java/yudao-ui-admin-vben-v5/apps/web-antd/src/utils/constants.ts；先不多个 apps 共享哈；
 const BpmModelType = {
   BPMN: 10, // BPMN 设计器
   SIMPLE: 20, // 简易设计器
diff --git a/apps/web-antd/src/views/bpm/model/index.vue b/apps/web-antd/src/views/bpm/model/index.vue
index bb59e3f7..64ef6646 100644
--- a/apps/web-antd/src/views/bpm/model/index.vue
+++ b/apps/web-antd/src/views/bpm/model/index.vue
@@ -162,6 +162,7 @@ const handleCategorySortSubmit = async () => {
 
 <template>
   <Page auto-content-height>
+    <!-- TODO @jaosn：没头像的图标，展示文字头像哈 -->
     <!-- 流程分类表单弹窗 -->
     <CategoryFormModal @success="getList" />
     <Card
diff --git a/apps/web-antd/src/views/infra/codegen/data.ts b/apps/web-antd/src/views/infra/codegen/data.ts
index e705dc24..ccc2c9de 100644
--- a/apps/web-antd/src/views/infra/codegen/data.ts
+++ b/apps/web-antd/src/views/infra/codegen/data.ts
@@ -159,6 +159,7 @@ export function useGenerationInfoBaseFormSchema(): VbenFormSchema[] {
       rules: 'selectRequired',
     },
     {
+      // TODO @puhui999：使用后端统一配置。因为一般需要批量的团队，会一直需要。不需要的，一般一直不需要哈。
       component: 'RadioGroup',
       fieldName: 'deleteBatch',
       label: '批量删除?',
diff --git a/apps/web-antd/src/views/infra/demo/demo01/data.ts b/apps/web-antd/src/views/infra/demo/demo01/data.ts
index ac29a04c..8c535168 100644
--- a/apps/web-antd/src/views/infra/demo/demo01/data.ts
+++ b/apps/web-antd/src/views/infra/demo/demo01/data.ts
@@ -151,6 +151,7 @@ export function useGridColumns(
       minWidth: 200,
       align: 'center',
       fixed: 'right',
+      // TODO @puhui999：headerAlign 要使用 headerAlign: 'center' 么？看着现在分成了 align 和 headerAlign 两种
       headerAlign: 'center',
       showOverflow: false,
       cellRender: {
diff --git a/apps/web-antd/src/views/infra/demo/demo01/index.vue b/apps/web-antd/src/views/infra/demo/demo01/index.vue
index 49df4616..4262d837 100644
--- a/apps/web-antd/src/views/infra/demo/demo01/index.vue
+++ b/apps/web-antd/src/views/infra/demo/demo01/index.vue
@@ -61,6 +61,7 @@ async function onDelete(row: Demo01ContactApi.Demo01Contact) {
   }
 }
 
+// TODO @puhui999：:1）/** 批量删除示例联系人 */ 是不是放在 deleteIds 上面；2）showDeleteBatchBtn 是不是直接 disabled 哪里判断哈；
 const deleteIds = ref<number[]>([]); // 待删除示例联系人 ID
 const showDeleteBatchBtn = computed(() => isEmpty(deleteIds.value));
 /** 批量删除示例联系人 */
diff --git a/apps/web-antd/src/views/system/role/index.vue b/apps/web-antd/src/views/system/role/index.vue
index c792f7ab..c198a402 100644
--- a/apps/web-antd/src/views/system/role/index.vue
+++ b/apps/web-antd/src/views/system/role/index.vue
@@ -55,6 +55,7 @@ function onCreate() {
 }
 
 /** 删除角色 */
+// TODO @星语：要不要改成 handleXXX 风格？貌似看着更多项目是这么写的，不去改变大家的习惯。
 async function onDelete(row: SystemRoleApi.Role) {
   message.loading({
     content: $t('ui.actionMessage.deleting', [row.name]),
diff --git a/apps/web-antd/src/views/system/tenant/index.vue b/apps/web-antd/src/views/system/tenant/index.vue
index 96d34894..0eba73d6 100644
--- a/apps/web-antd/src/views/system/tenant/index.vue
+++ b/apps/web-antd/src/views/system/tenant/index.vue
@@ -57,16 +57,21 @@ function onEdit(row: SystemTenantApi.Tenant) {
 
 /** 删除租户 */
 async function onDelete(row: SystemTenantApi.Tenant) {
-  message.loading({
+  const loading = message.loading({
     content: $t('ui.actionMessage.deleting', [row.name]),
     key: 'action_key_msg',
   });
-  await deleteTenant(row.id as number);
-  message.success({
-    content: $t('ui.actionMessage.deleteSuccess', [row.name]),
-    key: 'action_key_msg',
-  });
-  onRefresh();
+  try {
+    await deleteTenant(row.id as number);
+    message.success({
+      content: $t('ui.actionMessage.deleteSuccess', [row.name]),
+      key: 'action_key_msg',
+    });
+    onRefresh();
+  } finally {
+    // TODO @星语：测试了下，这样可以取消 loading；测试方式：1）先把数据库的数据，标记删除；2）点击界面，进行删除，loading 可以正确消失；
+    loading();
+  }
 }
 
 const [Grid, gridApi] = useVbenVxeGrid({